Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nighlty build failing #601

Closed
msevestre opened this issue Sep 8, 2021 · 8 comments · Fixed by #606 or #613
Closed

Nighlty build failing #601

msevestre opened this issue Sep 8, 2021 · 8 comments · Fixed by #606 or #613

Comments

@msevestre
Copy link
Member

This has been going on for a while
https://ci.appveyor.com/project/open-systems-pharmacology-ci/mobi/history
Due to SBML stuff. Please fix asap (it might already be fixed with PR merged this morning)
@abdelr @georgeDaskalakis

@abdelr
Copy link
Member

abdelr commented Sep 9, 2021

@msevestre I think it has to do with the changes on the MoBi.Engine\Sbml\SBMLImportRegister.cs file. It should be fixed when merging #599

@msevestre
Copy link
Member Author

@abdelr This is adding all the stuff that we have just removed. Please review the changes because what is proposed is not ok

@abdelr
Copy link
Member

abdelr commented Sep 9, 2021

I will take a look on Tuesday (I am on vacations tomorrow and Monday) but the changes proposed on Develop do not work and not only break some tests but also break the importer.

@msevestre
Copy link
Member Author

I merged the PR this morning so the fact that it is broken has nothing to do with this... it has been broken for many many days

@msevestre
Copy link
Member Author

image

@msevestre
Copy link
Member Author

over a month ago

@PavelBal
Copy link
Member

Still failing

@PavelBal PavelBal reopened this Sep 22, 2021
@PavelBal
Copy link
Member

@abdelr @georgeDaskalakis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants