Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with createPopulation #124

Closed
kmjob opened this issue Feb 11, 2021 · 12 comments
Closed

Issue with createPopulation #124

kmjob opened this issue Feb 11, 2021 · 12 comments
Assignees

Comments

@kmjob
Copy link

kmjob commented Feb 11, 2021

Hello,

While trying to run a simulation using the ospsuite R-package, I ran into an issue with creating a population (P_pop). When I use createPopulation, I think it is creating a list instead of a population. Typing "P_pop$" only gives a couple options and when I try to run the simulation I get the error below.

Error in validateIsOfType(population, Population, nullAllowed = TRUE) :
runSimulation: argument 'population' is of type 'list', but expected 'Population'!

Attached is a screenshot of my console. Has anyone run in to this issue before?

Thank you,
Kate

image

@PavelBal
Copy link
Member

May be a small usability issue... You have to pass

p_pop$population to runSimulation.

@msevestre
Copy link
Member

@kmjob The website documentation is outdated I believe
The vignettes should however reflect the correct usage

Moving this issue to our documentation repository

@AndreDlm
Copy link
Contributor

AndreDlm commented Feb 11, 2021

That's a weird issue and it should be added that exactly the same script, with the same pkml file and same R version works on my laptop. It seems that for some reasons createPopulation doesn't generate the same object when I run it on my laptop...

@msevestre msevestre transferred this issue from Open-Systems-Pharmacology/Forum Feb 11, 2021
@msevestre
Copy link
Member

@AndreDlm Which version of ospsuite-r are you using?

@msevestre
Copy link
Member

@Yuri05 How do you update the docs to have the latest vignettes?

@AndreDlm
Copy link
Contributor

@AndreDlm Which version of ospsuite-r are you using?

v 9.0.79

@kmjob
Copy link
Author

kmjob commented Feb 11, 2021

Thank you @msevestre, @PavelBal, and @AndreDlm: this worked! I will take closer look at the vignettes.

@msevestre
Copy link
Member

@AndreDlm Yes this is outdated
https://github.com/Open-Systems-Pharmacology/OSPSuite-R/releases/tag/v9.1.4

9.1 is the official first release and is not compatible with 9.0 on exactly this use case :)

@AndreDlm
Copy link
Contributor

Thanks @msevestre

@msevestre
Copy link
Member

@PavelBal I agree with you. I think the runSimulation should also support this object as parameter and extract the population if required. This would be just a better UX. I am going to create an issue for this

@msevestre
Copy link
Member

@PavelBal @AndreDlm This will be available in the next version of ospuite-r (either population or result fo create population) would work

@Yuri05
Copy link
Member

Yuri05 commented Jul 20, 2021

updated to latest vignettes in V10 docu

@Yuri05 Yuri05 closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants