Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A method for sender to return a buffer acquired via rpmsg_get_tx_payload_buffer #361

Closed
tammyleino opened this issue Mar 18, 2022 · 2 comments · Fixed by #401
Closed

A method for sender to return a buffer acquired via rpmsg_get_tx_payload_buffer #361

tammyleino opened this issue Mar 18, 2022 · 2 comments · Fixed by #401

Comments

@tammyleino
Copy link
Collaborator

I don't see a way for a sender to return a buffer to the pool in the case of tx failure. Is the only option to continue to try tx until the data is successfully sent? Has rpmsg_release_tx_buffer API been considered?

@arnopo
Copy link
Collaborator

arnopo commented Mar 21, 2022

Currently, nothing is implemented in Virtio to put the TX buffer back in the available list.
One use case that could justify this API would be that the endpoint is unbound before the send.
So yes this is something that seems to me appropriate to add

@arnopo
Copy link
Collaborator

arnopo commented Apr 14, 2022

FYI, I've started to investigate the problem and have a prototype that seems to address it.
unfortunately, not mature enough to send a pull request and too late for the 2022.04 release.
The corresponding code is available here: https://github.com/arnopo/open-amp/tree/tx_release
Any feedback on the solution is of course welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants