Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][csharp-netcore] Cancellation Tokens #7048

Closed
devhl-labs opened this issue Jul 24, 2020 · 4 comments · Fixed by #7077
Closed

[REQ][csharp-netcore] Cancellation Tokens #7048

devhl-labs opened this issue Jul 24, 2020 · 4 comments · Fixed by #7077

Comments

@devhl-labs
Copy link
Contributor

Please consider adding an optional CancellationToken to async calls similar to #6243.

@wing328
Copy link
Member

wing328 commented Jul 27, 2020

@devhl-labs thanks for the suggestion. May I know if you've time to contribute a PR with the enhancement?

@devhl-labs
Copy link
Contributor Author

devhl-labs commented Jul 27, 2020

I can give it a go. Do I do a pr for master, 5.0, or a new branch? In the issue I referenced there is a pr checklist, I don't understand the last bullet. Copy the technical committee. Sorry, copy what?

@wing328
Copy link
Member

wing328 commented Jul 27, 2020

Please target the current master (5.0.0-snapshot)

Please copy (cc or tag) the C# technical committee stated in https://github.com/OpenAPITools/openapi-generator#62---openapi-generator-technical-committee to review the PR.

@devhl-labs
Copy link
Contributor Author

I'm running mvn clean install which appears to succeed, then from .\bin\windows & ".\typescript.bat to update the samples, but that gives me an error of The goal you specified requires a project to execute but there is no POM in this directory (E:\repos\openapi-generator\bin\windows). Please verify you invoked Maven from the correct directory. I'm not sure how to update the samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants