Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build pika-tools #1341

Closed
2 tasks
wanghenshui opened this issue Mar 15, 2023 · 12 comments · Fixed by #1451
Closed
2 tasks

build pika-tools #1341

wanghenshui opened this issue Mar 15, 2023 · 12 comments · Fixed by #1451
Assignees

Comments

@wanghenshui
Copy link
Collaborator

  • build ok
  • add CI
@wanghenshui wanghenshui mentioned this issue Mar 15, 2023
78 tasks
@AlexStocks AlexStocks changed the title build: port-tools build pika-tools May 5, 2023
@AlexStocks
Copy link
Contributor

背景 :原来 pika-tools 都是在
https://github.com/Axlgrep/pika-tools 这里放着,现在只是把代码从 https://github.com/Axlgrep/pika-tools 迁移到了 https://github.com/OpenAtomFoundation/pika/tree/unstable/pika-tools,但是这些代码的底层依赖啥的都还没改为 https://github.com/OpenAtomFoundation/pika 下的代码,所以目前都没法编译。

工作:
1 把 makefile 改为 cmake;
2 编译通过;
3 其他工作。

@chenbt-hz
Copy link
Collaborator

golang开发的工具不需要改成cmake吧

@AlexStocks
Copy link
Contributor

golang开发的工具不需要改成cmake吧

这种当然不需要

@A2ureStone
Copy link
Contributor

aof_to_pika没有外部依赖,可以编译

@AlexStocks
Copy link
Contributor

A2ureStone

帮忙把 makefile 改为 cmake?

@A2ureStone
Copy link
Contributor

后面的很多tools的依赖目前pika都没有, 看下是否需要引入
https://github.com/Axlgrep/pika-tools/tree/master/third

@AlexStocks
Copy link
Contributor

https://github.com/Axlgrep/pika-tools/tree/master/third

不需要了,就把目前 pika-tools 目录下的项目改造好就行了,如果没法改造,就删掉。我们不再考虑支持 Pika v2 以及 nemo 相关的东西

@AlexStocks
Copy link
Contributor

@A2ureStone #1436 你这个 pr 缺少了如下改进:

  • 1 修改下 aof_to_pika 里面的 readme 中关于编译部分的内容;
  • 2 删除 aof_to_pika 里面的 makefile

@A2ureStone
Copy link
Contributor

目前除了aof_to_pika没有外部依赖, 其他tools都有依赖, 比如说slash, hiredis这种, 全删掉的话只剩下aof_to_pika了

@AlexStocks
Copy link
Contributor

目前除了aof_to_pika没有外部依赖, 其他tools都有依赖, 比如说slash, hiredis这种, 全删掉的话只剩下aof_to_pika了

slash 目前是 src/pstd,pink 目前是 src/net,blackwidow 目前是 src/storage。hiredis 如果缺的话,你加进来就是了。

@A2ureStone
Copy link
Contributor

rdb_to_pika目前shell脚本缺少依赖redis-rdb-tools,
pika-port txt_to_pika pika_to_txt缺少依赖bzip2,
看下是否需要引入

@AlexStocks
Copy link
Contributor

AlexStocks commented May 7, 2023

rdb_to_pika目前shell脚本缺少依赖redis-rdb-tools, pika-port txt_to_pika pika_to_txt缺少依赖bzip2, 看下是否需要引入

这个工程单独编译,不要引入根目录下的 cmake 文件中。单独编译的前提下,引入这些库是可以的。

总之要避免根工程引入太多的依赖。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants