fix: remove an unnecessary unlock operation in rsync throttle #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
☢️ Bug
wangshao1
approved these changes
May 17, 2024
chejinge
approved these changes
May 17, 2024
chejinge
pushed a commit
to chejinge/pika
that referenced
this pull request
May 21, 2024
Co-authored-by: cjh <1271435567@qq.com>
chenbt-hz
pushed a commit
to chenbt-hz/pika
that referenced
this pull request
Jun 3, 2024
Co-authored-by: cjh <1271435567@qq.com>
baerwang
pushed a commit
that referenced
this pull request
Jun 5, 2024
* removed keys_mutex.unlock() (#2657) Co-authored-by: cjh <1271435567@qq.com> * add metricx * fix * fix * fix * change import * fix flag * add lock * fix:code style * fix CI * Revert "Merge branch 'add_metrix' into add_metrix" This reverts commit 4202962, reversing changes made to 69069e2. * Revert "Merge pull request #19 from AlexStocks/add_metrix" This reverts commit 3651017, reversing changes made to 12a3ccc. * add_metricx * fix lock * fix panic * fix * fix review comment * fix:comment * fix cmdinfo --------- Co-authored-by: cheniujh <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: chejinge <chejinge@360.cn> Co-authored-by: alexstocks <alexstocks@foxmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Co-authored-by: cjh <1271435567@qq.com>
Merged
chejinge
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: cjh <1271435567@qq.com>
Merged
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Co-authored-by: cjh <1271435567@qq.com>
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* removed keys_mutex.unlock() (OpenAtomFoundation#2657) Co-authored-by: cjh <1271435567@qq.com> * add metricx * fix * fix * fix * change import * fix flag * add lock * fix:code style * fix CI * Revert "Merge branch 'add_metrix' into add_metrix" This reverts commit 4202962, reversing changes made to 69069e2. * Revert "Merge pull request OpenAtomFoundation#19 from AlexStocks/add_metrix" This reverts commit 3651017, reversing changes made to 12a3ccc. * add_metricx * fix lock * fix panic * fix * fix review comment * fix:comment * fix cmdinfo --------- Co-authored-by: cheniujh <41671101+cheniujh@users.noreply.github.com> Co-authored-by: cjh <1271435567@qq.com> Co-authored-by: chejinge <chejinge@360.cn> Co-authored-by: alexstocks <alexstocks@foxmail.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
cheniujh
added a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Co-authored-by: cjh <1271435567@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ThrottledByThroughput function, keys_mutex is already managed by unique_lock, so there's no need to manually unlock it.
在ThrottledByThroughput函数中，keys_mutex已经被unique_lock托管，没必要手动解锁。