Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:mget supports cache querying multiple keys #2675

Merged
merged 8 commits into from
Jun 4, 2024
Merged

feat:mget supports cache querying multiple keys #2675

merged 8 commits into from
Jun 4, 2024

Conversation

chejinge
Copy link
Collaborator

@chejinge chejinge commented May 23, 2024 •
edited
Loading

#2612

1.这个PR主要添加上述issue的feat:
查询方式，先查询cache，记录未命中的key，有一个未命中去DB中查询，查到后进行组装

2.bug 修复1:当flushdb后disablecacheflag导致cache不能继续使用

3.bug修复2:修复cache存feild个数限制时候不需要设置disable flag

4.之前的测试因为需要flushdb ，因此会导致测试的时候cache根本就没开，本次开启后发现 redis4.0和pika因为bitpos和bitget命令实现方式不一致 导致有些TCL边界测试用例通不过，暂时将这两个命令的flag关闭，待升级后一并打开

@github-actions github-actions bot added the ☢️ Bug Something isn't working label May 23, 2024
@chejinge chejinge force-pushed the multi_get branch 4 times, most recently from fe7bdab to 518171e Compare May 27, 2024 10:04
@chejinge chejinge changed the title fix:multi get feat:mget supports cache querying multiple keys May 27, 2024
@github-actions github-actions bot added the ✏️ Feature New feature or request label May 27, 2024
@chejinge chejinge force-pushed the multi_get branch 2 times, most recently from 759d335 to b855371 Compare May 27, 2024 15:47
@chejinge chejinge requested review from AlexStocks and cheniujh May 28, 2024 03:16
AlexStocks
AlexStocks reviewed May 28, 2024
View reviewed changes
src/pika_bit.cc Outdated Show resolved Hide resolved
cheniujh
cheniujh reviewed Jun 3, 2024
View reviewed changes
src/pika_kv.cc Outdated Show resolved Hide resolved
@chejinge chejinge requested a review from wangshao1 June 3, 2024 10:27
AlexStocks
AlexStocks reviewed Jun 3, 2024
View reviewed changes
include/pika_kv.h Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 1bb76ed into OpenAtomFoundation:unstable Jun 4, 2024
12 checks passed
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
@chejinge @brother-jin
feat:mget supports cache querying multiple keys (OpenAtomFoundation#2675
d0ab081 
)

* multi get

---------

Co-authored-by: chejinge <chejinge@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@wangshao1 wangshao1 wangshao1 approved these changes

@cheniujh cheniujh cheniujh approved these changes

@baixin01 baixin01 baixin01 approved these changes

Assignees
No one assigned
Labels
☢️ Bug Something isn't working ✏️ Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chejinge @AlexStocks @wangshao1 @cheniujh @baixin01 @brother-jin