Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas-market-calendars required but not in requirements.txt #1638

Closed
hurricane-dorian opened this issue Apr 5, 2022 · 3 comments · Fixed by #1640
Closed

pandas-market-calendars required but not in requirements.txt #1638

hurricane-dorian opened this issue Apr 5, 2022 · 3 comments · Fixed by #1640
Assignees
Labels
bug Fix bug

Comments

@hurricane-dorian
Copy link

pandas-market-calendars is required to run terminal.py
It is in requirements-full.txt but not in requirements.txt

I just used pip install -r requirements.txt in Linux instead of using anaconda

@piiq
Copy link
Contributor

piiq commented Apr 5, 2022

Hey @hurricane-dorian

Have you tried using poetry for dependency management? We've adopted poetry for this project and everyone seems to like it.

In the project root in your venv (or other python environment) you can do:

pip install poetry
poetry install

and poetry will install all the requirements from the .lock file.

The requirements.txt that are in the repo might be lagging behind poetry.lock a bit

@hurricane-dorian
Copy link
Author

In poetry.lock "pandas-market-calendars" is marked as a dev package but it is required to run

@piiq piiq self-assigned this Apr 5, 2022
@piiq piiq added the bug Fix bug label Apr 5, 2022
@piiq
Copy link
Contributor

piiq commented Apr 5, 2022

In poetry.lock "pandas-market-calendars" is marked as a dev package but it is required to run

That's a good catch! Thanks a lot. This issue will be closed once the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants