Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] (Portfolio) Loading external Portfolio files fail #2101

Closed
jfarid27 opened this issue Jul 18, 2022 · 1 comment · Fixed by #2091
Closed

[Bug] (Portfolio) Loading external Portfolio files fail #2101

jfarid27 opened this issue Jul 18, 2022 · 1 comment · Fixed by #2091
Assignees
Labels
bug Fix bug portfolio Portfolio menu

Comments

@jfarid27
Copy link
Contributor

jfarid27 commented Jul 18, 2022

Describe the bug

portfolio Load doesn't accept an external csv, and crashes the application when attempted.

To Reproduce

  1. Navigate to portfolio.
  2. Run load -f <your file>.
  3. The application will crash and produce an error that the option is not an available option.

Screenshots
Screen Shot 2022-07-17 at 9 38 38 PM

Desktop (please complete the following information):

  • OS: Mac OS
  • Python version 3.8.13
  • Version: 1.5.0 (Bug is confirmed on 1.5.0)

Additional context

https://github.com/OpenBB-finance/OpenBBTerminal/blame/main/openbb_terminal/portfolio/portfolio_controller.py#L290

I believe this was added here accidentally. This forces the user to only be able to select from these choices, instead of having the user be able to load from an external source. The other issue is once that line is cleared, I can't load a file directly since the terminal grabs forward-slash "/" characters. I believe there needs to be some kind of escape character added for "/".

@github-actions github-actions bot added bug Fix bug portfolio Portfolio menu labels Jul 18, 2022
@montezdesousa
Copy link
Contributor

@jfarid27 thanks for pointing this.

I'll address the choices issue as it is creating problems with exporting transaction files from degiro menu as well (#2091).

Regarding path I believe it is related with this #2064. After removing choice restrictions and passing a path with back-slash it appears to work on my end. But I'll get back to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug portfolio Portfolio menu
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants