Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ETF/search --export. Error: 'dict' object has no attribute 'replace' #3654

Closed
deeleeramone opened this issue Nov 29, 2022 · 4 comments
Closed
Labels
bug Fix bug

Comments

@deeleeramone
Copy link
Contributor

/etf/search fails to export.

Error: 'dict' object has no attribute 'replace'

Screenshot 2022-11-29 at 9 03 56 AM

@deeleeramone deeleeramone added the bug Fix bug label Nov 29, 2022
@victortangggg
Copy link
Contributor

seems like the reason is because the data type that is passed in as parameter for export_data(...) is of dict while it is expected to be of data type pd.dataframe

image

in export_data the parameter was handled as dataframe
image

suggestion
replace data with table_data_sorted
image

@victortangggg
Copy link
Contributor

happy to commit the change and create a pull request if there's no issue.

@jmaslek
Copy link
Collaborator

jmaslek commented Nov 29, 2022

happy to commit the change and create a pull request if there's no issue.

Feel free to do so!

@victortangggg
Copy link
Contributor

PR created under #3664
please let me know if im doing this correctly thanks!

@jmaslek jmaslek closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

No branches or pull requests

3 participants