Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] stocks/fa/info - Error: Yahoo has again changed data format, yfinance now unsure which key(s) is for decryption #4044

Closed
deeleeramone opened this issue Jan 25, 2023 · 7 comments · Fixed by #4155
Labels
bug Fix bug

Comments

@deeleeramone
Copy link
Contributor

Recreate with:

/stocks/load aapl/fa/info

image

Related to this: ranaroussi/yfinance#1329

@deeleeramone deeleeramone added the bug Fix bug label Jan 25, 2023
@JerBouma
Copy link
Contributor

JerBouma commented Jan 25, 2023

Just fyi, this applies to anything regarding Yahoo Finance (stocks/quote, stocks/sia, stocks/fa and stocks/options). It pretty much always includes this error message when you run something even if it does work like /stocks/load aapl/fa/income.

@deeleeramone
Copy link
Contributor Author

deeleeramone commented Jan 25, 2023

/Portfolio, Portfolio/PO, /reports, /etf, /crypto, basically every menu will have problems because of this.

@kajdo
Copy link
Contributor

kajdo commented Jan 26, 2023

obvious - but to keep the error report complete .... affects also the sdk

@kajdo
Copy link
Contributor

kajdo commented Jan 27, 2023

no guarantee that it fixes your issue - but just followed up on the issue on yfinance git and their community and devs are pretty awesome (ranaroussi/yfinance#1329)

as said - no guarantee ... but first tests on my side were successful changing the pip package via

pip install git+https://github.com/ranaroussi/yfinance.git@main

there is an issue reported by pip because openbb has a dependency to a specific yfinance version - but it fixed my issue

edit:
i think there might be some changes necessary on openbb side as well ... see
image

@JerBouma
Copy link
Contributor

Hi @kajdo,

Given the instability of yfinance, we're opening PRs to become less reliant on Yahoo Finance so that most functionality will continue to work despite Yahoo Finance breaking. We've noticed that market data seems to function properly 99% of the time whereas other functionality breaks so we are changing the default source. For example see #4055.

@kajdo
Copy link
Contributor

kajdo commented Jan 27, 2023

@JerBouma think that's a good thing - at least for core functionalities ... that will make openbb much more stable i guess (even though the yfinance project is great, its always up to yahoo when they decide to change something)

will see if i can help out somehow

@JerBouma
Copy link
Contributor

@JerBouma think that's a good thing - at least for core functionalities ... that will make openbb much more stable i guess (even though the yfinance project is great, its always up to yahoo when they decide to change something)

will see if i can help out somehow

Yes, that's our thinking too. It is a bit unfortunate that many functionalities break as soon as yfinance stops working. With these changes, we are less reliant on that package making it possible to use the same version much longer. Any help is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants