Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer links and styles #91

Open
nam-m opened this issue Feb 4, 2024 · 0 comments
Open

Fix footer links and styles #91

nam-m opened this issue Feb 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@nam-m
Copy link
Collaborator

nam-m commented Feb 4, 2024

Some issues with the footer
Previous PR: #83

UI

  1. Links showing blue (instead of black) on deployed website (pointed out by @Unknown-0perator)
  1. The footer navigation links are underlined and Join Us is highlighted. We probably don't want this. I see that 'Join Us' is highlighted in Figma wireframe but it's probably only example of how every nav link should look like on hover.

  2. Github and LinkedIn svg icons are not colored

  3. The footer wrapper container has a visible line at border-top on the deployed web

    Image

    Image

Functionalities

  1. No need to link OpenBC button since it directs to the homepage anyways

  2. Subscribe, Terms of Service, Privacy Policy should not direct anywhere as they are not available yet. Maybe show a small dialog saying it is not available when getting clicked. The dialog should be positioned at the bottom and not intrusive

  3. Contact Us might direct to OpenBC's email, check with Toki to make sure.

  4. Footer is not at the bottom of the page on Join us and About pages
    Image

    Image

@nam-m nam-m converted this from a draft issue Feb 4, 2024
@nam-m nam-m moved this to 🆕 New in openbc-website Feb 4, 2024
@nam-m nam-m added bug Something isn't working enhancement New feature or request labels Feb 4, 2024
@nam-m nam-m changed the title Fix footer link and styles Fix footer links and styles Feb 4, 2024
@Unknown-0perator Unknown-0perator self-assigned this Feb 5, 2024
@Unknown-0perator Unknown-0perator moved this from 🆕 New to 🏗 In progress in openbc-website Feb 11, 2024
@Unknown-0perator Unknown-0perator moved this from 🏗 In progress to 👀 In review in openbc-website Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants