Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest]bmt.OpTransformerBlockList **DO NOT** support multiple return values of transformer block's forward propogation #91

Closed
eggiter opened this issue Apr 28, 2023 · 1 comment
Assignees

Comments

@eggiter
Copy link

eggiter commented Apr 28, 2023

1. Currently bmt.OpTransformerBlockList can only handle the hidden states returned by transformer block.

  1. Recent released flash_atten implemented transformer block returns hidden_states as well as residual in order to fuse Dropout -> Add -> LN. Additionally, the above two will be passed to the next block as input;
  2. Above case seemed not be considered by our bmt.OpTransformerBlockList and cannot be properly handled by us.

2. Request to support the above case which returns multiple values by a transformer block.

@eggiter
Copy link
Author

eggiter commented May 5, 2023

Close this issue since feature was supported by #92

@eggiter eggiter closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants