Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Weird thumbnail issue in Purchases #602

Closed
hoffmabc opened this issue Aug 2, 2017 · 2 comments · Fixed by #603
Closed

Weird thumbnail issue in Purchases #602

hoffmabc opened this issue Aug 2, 2017 · 2 comments · Fixed by #603
Assignees

Comments

@hoffmabc
Copy link
Member

hoffmabc commented Aug 2, 2017

On Milestone 3 I'm seeing possibly a bad crop thumbnail of the order.

I'm not sure if this image is the avatar or the item, but it's clearly neither at the moment.

image

@rmisio
Copy link
Contributor

rmisio commented Aug 2, 2017

This is a product of auto-cropping. You need to choose where to crop (center, top-left, top-right, etc...). No matter where you choose, it's not going to work for all images.

At some point we could look into integrating a cropper into the Create Listing modal, so the user could choose the cropping, but there's some scope there. That's an already super complicated screen.

Also, I'm not sure we have one specific target dimension. For example, if the user crops to a certain dimension, can that dimension be used in all the places we need a listing image (store, search, listing detail, order detail, etc...) -or- do we need to have the user choose multiple crops? If it's the latter, then the server would need to updated to store additional versions of a listing image.

I don't think this is something we will solve by launch.

@rmisio rmisio added the bug label Aug 2, 2017
@rmisio
Copy link
Contributor

rmisio commented Aug 2, 2017

Ok... this might be a bug in the cropping algorythm on the server. While auto crop isn't going to be perfect, it should be better than what that screenshot depicts. It looks like the image is overhanging (by a large amount) over both dimensions and it should at most overhang on one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants