Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static and shared build releases are equal #208

Closed
laborg opened this issue Feb 23, 2023 · 7 comments · Fixed by #209
Closed

Static and shared build releases are equal #208

laborg opened this issue Feb 23, 2023 · 7 comments · Fixed by #209

Comments

@laborg
Copy link
Contributor

laborg commented Feb 23, 2023

First off, thanks for publishing SimpleBLE as shared lib.
I was looking forward to use them to create Julia bindings, but it turns out that they are equal to the static lib versions.

@kdewald
Copy link
Member

kdewald commented Feb 23, 2023

@laborg thanks for the fix! Can you send me the link to your project so that I can send people your way?

@laborg
Copy link
Contributor Author

laborg commented Feb 24, 2023

@kdewald As soon as they are released I will tag you. The idea is to create two projects:

@laborg
Copy link
Contributor Author

laborg commented Feb 27, 2023

@kdewald
The builds for

  • simpleble_shared_linux-armv6.zip
  • simpleble_shared_linux-x86.zip
    still include the static libraries. Should CI automatically upload binary artifacts resulting from a merged PR or is there a manual step involved?

@kdewald kdewald reopened this Feb 27, 2023
@kdewald
Copy link
Member

kdewald commented Feb 27, 2023

@laborg There's something broken in the build process that I still need to debug, so those two will be wrong for a while longer while I figure it out.

@laborg
Copy link
Contributor Author

laborg commented Feb 28, 2023

Could it be that this is a timing problem with parallel builds?

@kdewald
Copy link
Member

kdewald commented Feb 28, 2023

No, this is an architecture problem. CMake tries to link to an incorrect DBus library file. It should be somewhat straightforward to fix.

@kdewald kdewald added this to the SimpleBLE v0.6.X milestone Mar 19, 2023
@kdewald
Copy link
Member

kdewald commented Mar 19, 2023

This was fixed in v0.6.1

@kdewald kdewald closed this as completed Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants