Knowledge retention rules also delete organizations

[Archidoit]

Description

Knowledge retention rules also delete organizations, which can lead to issues.

Reproducible Steps

• Create a retention rule on scope Knowledge with no filters (or filters different from entity_type = XX)
• The retention rule will also delete organizations (logical because they are stix domain objects)
  It may raise issues, for instance if the platform organization or a user organization is deleted.

Comment

It seems that this has always been the case.

Proposed solutions

Different solutions are possible:

• Add a warning message if a retention rule may delete organizations
• Exclude organizations from knowledge retention rules deletion scope

[labo-flg]

unsure it's a bug, more like a new feature. Being able to delete knowledge means deleting organizations too.
For users not using organization sharing for instance, this can be OK I guess

We can think of various improvements:

• warn callout when the platform organization is set, to warn about deleting organizations.
• have a checkbox "prevent deleting organizations"
• have a fixed filter that user cannot remove "entity type NOT Organization.
  ....

[romain-filigran]

@Jipegien @nino-filigran : Another argument for dissociating "knowledge" organizations from "sharing" organizations.