Auto save feature

[ghutchis]

Avogadro should support an auto-save feature, eg something like https://github.com/faiszalkhan/SimpleAutosave

Save unsaved molecules to the auto save directory every 5 minutes.

[harxish]

@ghutchis Is this still open? Can I work on this?

[ghutchis]

Thanks, yes, it's still open - would certainly love to see some help. Do you need more tips / mentoring?

[harxish]

Yea, that would be really great.

Cloud you tell me where to start ?

[Abhisharma85]

Is this open ? I want to work on this

[harxish]

@Abhisharma85 yup this is open. You can work on this.

[VARUN-009]

I wanna work on this issue. Please assign this to me and since I'm new to this repo so I request you to please guide me through.

[Aadijindal07]

hi i would love to work on it kindly assign

[ghutchis]

In this project, we do not assign issues except to indicate that a core developer is currently working on something. If you would like to start, please do. There's an example repo linked above.

[ShubhamKumar977]

@ghutchis where can I find the piece of code that saves the code on clicking save?

[ghutchis]

@ShubhamKumar977 - I'm not quite sure what you're asking. Do you want to see the example AutoSave code (see my first comment in the thread) or how Avogadro currently implements a save signal?

[ShubhamKumar977]

@ShubhamKumar977 - I'm not quite sure what you're asking. Do you want to see the example AutoSave code (see my first comment in the thread) or how Avogadro currently implements a save signal?

@ghutchis I want to know how Avogadro currently implements a save signal?

[ghutchis]

You'll either want:

avogadroapp/avogadro/mainwindow.cpp

Line 1330 in f1b42f0

bool MainWindow::saveFile(bool async)

Or

avogadroapp/avogadro/mainwindow.cpp

Line 1460 in f1b42f0

bool MainWindow::saveFileAs(const QString& fileName, Io::FileFormat* writer,

[ghutchis]

I would suggest saving as .cjson, e.g.
writer = new Io::CjsonFormat;

[Aenk-Singhal]

is it still open for me to work on ?

[ghutchis]

I still haven't seen a pull request, so yes.

[avo-bot]

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/how-to-contribute/4569/12

[Atharva-Kanherkar]

The issue seems open. But it's very old, so is it open until now? @ghutchis If yes, i'd like to start working on it. The
progress would be a little slow as my exams are going on, but will sure move ahead.

[ghutchis]

@Atharva-Kanherkar - it's definitely still open. As I mention above, I'm happy to help / mentor.

[Atharva-Kanherkar]

@Atharva-Kanherkar - it's definitely still open. As I mention above, I'm happy to help / mentor.

Thank you! For starters, ive been understanding the codebase. I will say ill spend one or two days on understanding the code base, and then start working on this. Can you provide me some more information about how i can start, itd be much helpful:)

[Atharva-Kanherkar]

Until then, @ghutchis , if there are any documentation and translation tasks (I know hindi pretty well for starters) I can do it while studying the codebase.

[ghutchis]

@Atharva-Kanherkar - any work on Hindi would be greatly appreciated:
https://hosted.weblate.org/engage/avogadro/

That's all automatically synced - it will show up in avogadroapp and avogadrolibs as pull requests.

[Atharva-Kanherkar]

@Atharva-Kanherkar - any work on Hindi would be greatly appreciated: https://hosted.weblate.org/engage/avogadro/

That's all automatically synced - it will show up in avogadroapp and avogadrolibs as pull requests.

Sure! Ill start working.

[Atharva-Kanherkar]

Hi, @ghutchis. I have prepared a google doc to make a roadmap - task bar kind of thing for the future of the implementation.
Can you please review the doc and tell me if everything's correct so i start working on it? This is just a simple list of tasks id need to do.
Thank you!
Here is the link : https://docs.google.com/document/d/1yA0rhWgOiO00GeKlP8gpGtTGhAV7YYryjLGmjCTkBt8/edit?usp=sharing

[Atharva-Kanherkar]

Hi, @ghutchis may i start working?

[ghutchis]

Sure, of course.

A few notes, since I cannot comment on that Google doc:

• For the temporary auto-save file, you will want to use https://doc.qt.io/qt-6/qtemporaryfile.html
• For example, here is related code that saves to a temporary file (line 78-97) https://github.com/OpenChemistry/avogadrolibs/blob/bcf2b3dcf8f7d715b8d2e5ef597a5398bf20d6b8/avogadro/qtplugins/forcefield/scriptenergy.cpp#L78
• Unlike that code, you will want to use the ".cjson" format (Io::CjsonFormat)
• There is already code for manual saves, e.g.

  avogadroapp/avogadro/mainwindow.cpp

  Line 1367 in 3456a09

  bool MainWindow::saveFile(bool async)

  and related methods

As you said, we're happy to help with advice and testing - submit a pull request and mark it as "WIP" for work in progress to get code review, run the auto builds, etc.

[Atharva-Kanherkar]

Hi, @ghutchis do you have any resources (videos/documentation) to brush up my knowledge of QT?

[ghutchis]

https://www.qt.io/academy
https://doc.qt.io/qt-5/classes.html

In reality, I suggest you start by looking at the "SimpleAutosave" example and consider what it does.

You can also start by making sure you can build Open Chemistry.

[avo-bot]

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/help-finding-teaching-materials/4993/8