Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Destructors Never Get Called? #389

Closed
psavery opened this issue Sep 19, 2018 · 2 comments
Closed

Plugin Destructors Never Get Called? #389

psavery opened this issue Sep 19, 2018 · 2 comments
Labels

Comments

@psavery
Copy link
Collaborator

psavery commented Sep 19, 2018

Hi all,

I've been running some tests, and it seems to me that the plugin destructors do not actually get called.

I tested it out by trying to print a message in several different plugin destructors (copypaste, openbabel, plotxrd, and select were the ones I tried).

Can anyone else confirm this? I was going to use the destructors to help make sure the Vtk plot (in PR #379) gets closed when the program exits..
Patrick

@welcome
Copy link

welcome bot commented Sep 19, 2018

Thanks for opening your first issue here! Please try to include example files and screenshots if possible. If you're looking for support, please post on our forum: https://discuss.avogadro.cc/

@cryos
Copy link
Member

cryos commented Apr 16, 2023

Ancient bug, but fixed in OpenChemistry/avogadroapp#363 where the MainWindow should be on the stack, and then the plugin instances should have a parent passed in. Verified that destructors are called and opened #1250 to fix a bug where a plugin was deleting the molecule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants