Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Guard Protocol in oc_particles.lsl #973

Closed
NikkiLacrima opened this issue Aug 2, 2023 · 1 comment
Closed

Lock Guard Protocol in oc_particles.lsl #973

NikkiLacrima opened this issue Aug 2, 2023 · 1 comment
Assignees

Comments

@NikkiLacrima
Copy link
Contributor

NikkiLacrima commented Aug 2, 2023

While checking the code in oc_particles.lsl it seems that the current implementation does not handle repeated [command variable(s)] sections correctly. So this post is to check my understanding of the protocol before trying to create a working patch.

According to https://wiki.secondlife.com/wiki/LSL_Protocol/LockGuard, the only command that should send the target prim key is "link", this means that the lacking link target discussed in #965 is according to the protocol specifications. This is also means that size, color, texture and gravity can be expected in the same command as the link command, this corresponds to observed behaviour from some LG furniture I tested, or can be sent in separate commands, currently not handled by the code since it assumes key kLGTarget = llList2Key(lLGCmd,4) for all commands and uses this to get the distance.

Do we want to accept parameter commands, even if kLGTarget is not known, but the leash point is correct ?

For the code in oc_particle this means

  • ?? kLGTarget should be made global, or one copy for every leash point. ??
  • LG handling should loop over the command line, or check the complete set of commands one by one.
  • "link" and the call to Particle() should be handled last in order to parse eventual parameters first.

Update:
There is a test version of updated Lock Guard implementation in
NikkiLacrima@ff098a1

@NikkiLacrima
Copy link
Contributor Author

Implemented in PR #974, tested and working so far

@github-project-automation github-project-automation bot moved this from Discuss Feature to Done in OpenCollar Issues Board Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants