Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCDS: internal server error when declaring bids extension with invalid 1.0 data #1111

Closed
duncandewhurst opened this issue Jan 28, 2019 · 2 comments

Comments

@duncandewhurst
Copy link
Contributor

The data review tool reports an internal server error when you submit data with the following characteristics:

  • No version key is declared, or version is declared as 1.0
  • Bids extension is declared
  • bids/statistics/value is a string rather than a number

Minimal example to reproduce the error:

{
    "publisher": {
        "name": " "
    },
    "license": "https://example.com",
    "publicationPolicy": "https://example.com",
    "releases": [
        {
            "language": "en",
            "ocid": " ",
            "bids": {
                "statistics": [
                    {
                        "date": "2019-01-28T11:19:05.039413+00:00",
                        "notes": " ",
                        "id": " ",
                        "value": "1",
                        "measure": " "
                    }
                ]
            },
            "initiationType": "tender",
            "tag": [
                "award"
            ],
            "date": "2019-01-28T11:19:05.039413+00:00",
            "id": " "
        }
    ],
    "publishedDate": "2019-01-28T11:19:05.039413+00:00",
    "uri": "https://example.com",
    "extensions": [
        "https://raw.githubusercontent.com/open-contracting/ocds_bid_extension/v1.1.3/extension.json"
    ]
}
@Bjwebb
Copy link
Member

Bjwebb commented Nov 4, 2019

I think I've recently come across the same problem, and fixed it in lib-cove-ocds. open-contracting/lib-cove-ocds#37

This should be fixed in CoVE once we use the latest lib-cove-ocds release, which should be when we merge #1241

@jpmckinney
Copy link

Can be closed?

@Bjwebb Bjwebb closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants