Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of validation messages from within oneOf #126

Closed
Bjwebb opened this issue Oct 2, 2019 · 3 comments
Closed

Remove duplication of validation messages from within oneOf #126

Bjwebb opened this issue Oct 2, 2019 · 3 comments
Labels
check results Relating to how specific checks are reported

Comments

@Bjwebb
Copy link
Contributor

Bjwebb commented Oct 2, 2019

Introduced as part of OpenDataServices/cove#895 when we replaced the monolithic oneOf validation messages with the individual messages for each subschema.

Errors about date and tag being required can come from either subschema, and are repeated for each.

This is only a problem for files that have a mix of assumed embedded and linked releases for different records.
@robredpath
Copy link
Contributor

@Bjwebb is this fixed now?

@robredpath robredpath transferred this issue from OpenDataServices/cove Oct 14, 2020
@Bjwebb
Copy link
Contributor Author

Bjwebb commented Oct 14, 2020

No, this is a fairly specific edge case with the oneOf work we've done, that we might be happy to just not deal with.

@robredpath robredpath transferred this issue from another repository Oct 14, 2020
@jpmckinney jpmckinney added the check results Relating to how specific checks are reported label Oct 14, 2020
@jpmckinney jpmckinney mentioned this issue Oct 14, 2020
Open
@jpmckinney
Copy link
Member

This is only a problem for files that have a mix of assumed embedded and linked releases for different records.

This very rarely (if ever) occurs, so okay to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
check results Relating to how specific checks are reported
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bjwebb @jpmckinney @robredpath