Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error notice related to odm/menu #1344

Open
S-mardii opened this issue Jan 23, 2023 · 5 comments
Open

Error notice related to odm/menu #1344

S-mardii opened this issue Jan 23, 2023 · 5 comments

Comments

@S-mardii
Copy link
Collaborator

On Widget page of PP, there are some error message: https://pp.opendevelopmentcambodia.net/wp-admin/widgets.php

Notice: Function register_rest_route was called incorrectly. The REST API route definition for odm/menu is missing the required permission_callback argument. For REST API routes that are intended to be public, use __return_true as the permission callback. Please see [Debugging in WordPress](https://wordpress.org/support/article/debugging-in-wordpress/) for more information. (This message was added in version 5.5.0.) in /var/www/html/wp-includes/functions.php on line 5835

image

Some resources to look at:

@S-mardii
Copy link
Collaborator Author

@EricSoroos do we expect to expose the odm/menu publicly?

@S-mardii
Copy link
Collaborator Author

There is also a long list of Warning for the Custom Widget to be fixed on this page:

image

@S-mardii
Copy link
Collaborator Author

S-mardii commented Jan 23, 2023

There is also a long list of Warning for the Custom Widget to be fixed on this page:

image

Based on search through the internet, the issue could be resolved by installing a plugin call Classic Widget.

Source: https://wordpress.org/support/topic/widgets-problem-19/

@EricSoroos
Copy link
Contributor

I don't think that's actually used, I added that originally to get the menu data as json, but then we had to fall back to just scraping the menu html and using the javascript/css directly to make it match the styles. I think we can just drop that REST api end point.

We can also add the classic widget plugin, at least in the current version prior to upgrading to the block editor.

@EricSoroos
Copy link
Contributor

I've added the classic widget plugin to the PP site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants