Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet reader never outputs particles with moving=0 #1321

Open
poplarShift opened this issue Jun 20, 2024 · 2 comments
Open

parquet reader never outputs particles with moving=0 #1321

poplarShift opened this issue Jun 20, 2024 · 2 comments

Comments

@poplarShift
Copy link
Contributor

Hi, in #1259 I proposed a module to write to parquet files.

Now I'm noticing that it does not seem to ever output values where moving==0. As all other values seem to be correct, there must be something I do not understand about .history.

Is maybe this line to blame, and .mask masks out more than I thought?

~self.history[k].mask[:, 0:num_steps_to_export]

If you do not have a good idea off the top of your heads, I'll try and debug with an MWE.

@knutfrode
Copy link
Collaborator

Hi,
There should actually not be anything specific about moving, it is just a particle property like any other proerties like length, lon, lat etc.
Thus I am not able to see immediately what could cause these problems.

However, in the (near?) future, we consider to change the datatype for history from record array to Xarray Dataset. This should hopefully simplify many things internally in OpenDrift.

@poplarShift
Copy link
Contributor Author

Thanks - I'll try and set up an MWE, but will likely be a while before I find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants