Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action that tests functionality for PRs #10

Open
11 tasks
hendrikebbers opened this issue Oct 15, 2024 · 4 comments
Open
11 tasks

Add github action that tests functionality for PRs #10

hendrikebbers opened this issue Oct 15, 2024 · 4 comments
Labels
good first issue Reserved for newcomers 🐣 help wanted External contribution or help is welcome 🧑‍💻🧑🏾‍💻

Comments

@hendrikebbers
Copy link
Member

hendrikebbers commented Oct 15, 2024

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to this project or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution.

👾 Description of the issue

Today, we have some actions that can be triggered manually to check the functionality of the main branch. We need to refactor the actions or create new ones triggered at a PR to check that the PR changes will not destroy the functionality.

The current actions can be found here:

To solve the issue one or several actions need to be created that internally use the provided action of the repo and check the state after the execution. In the given actions we only echo information. Instead of that we need to check the output.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: to your branch
  • Start a Pull Request (PR): in the hedera-enterprise repository
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the community for support.
  • Wait for reviews: Members of the community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of our community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional informantion

If you have any questions, just ask us directly in this issue by adding a comment. You can join the Hedera community chat at Discord. A general manual about open-source contributions can be found here.

@mohammedfirdouss
Copy link
Contributor

@hendrikebbers I would like to work on this

@hendrikebbers hendrikebbers added the hacktoberfest Reserved for Hacktoberfest contribution (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻 label Oct 17, 2024
@namay26
Copy link

namay26 commented Oct 17, 2024

@hendrikebbers I would like to work on this.

@megha-66
Copy link
Contributor

can you assign this to me please? @hendrikebbers

@PentesterPriyanshu
Copy link

@hendrikebbers can you assign this to me

@hendrikebbers hendrikebbers added good first issue Reserved for newcomers 🐣 help wanted External contribution or help is welcome 🧑‍💻🧑🏾‍💻 and removed hacktoberfest Reserved for Hacktoberfest contribution (see https://hacktoberfest.com) 🚀👾🧑🏽‍💻 labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Reserved for newcomers 🐣 help wanted External contribution or help is welcome 🧑‍💻🧑🏾‍💻
Projects
None yet
Development

No branches or pull requests

5 participants