-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import from stato #21
base: main
Are you sure you want to change the base?
Conversation
@LillyG901 I put some more information into the header of the PR. What about confidence interval, which is also mentioned in the original issue? |
Alright, thank you. Since I will check that this is the case, when I get to test the shell script. |
the previous upper term leads to import of more terms than necessary
I misinterpreted the hierarchy on the website I was looking at. |
Can you avoid importing all information of annotation properties? Most of the annotation properties are known by oeo. If we import them again, we have them twice (we had that in the past). Mentioning the IRI should be sufficient. But I am not sure how to achieve that automatically. Maybe you can find that out by reading the ROBOT documentation. |
I assumed duplicates might cause problems, since we did not import e.g. the BFO parent classes of the iao classes that were imported.
I will look into it. |
Yes, you're right. You don't have to change that, sorry. We'll have to add the SubClassOf axiom in oeo-import-edits.owl |
Alright after some research I found a way to remove the definitions of the annotation properties. If you open the stato-extracted file in Protege, you should now be able to see the IRI of the annotation property instead of the label and the term is no longer defined if you check the Annotation-Property tab. I checked the other import files and we have never really done this before, so it would be great if someone could test this and make sure this is what I should be doing. |
This looks good now, thanks. |
Summary of the discussion
See issue #7 and OpenEnergyPlatform/ontology#1133
Type of change (CHANGELOG.md)
Add
Workflow checklist
Automation
Closes #7
PR-Assignee
term tracker annotation
Reviewer