You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BeamDyn includes an additional layer of coordinate transformations that is no longer necessary and breaks the framework. Prior to pull request #1771, all BeamDyn states were calculated against a fixed reference frame set by the initial blade root reference position. During a call to CalcOutput or UpdateStates, the inputs were copied and transformed into this reference by the BD_InputGlobalLocal routine.
After #1771, the reference frame for all states has been changed to a moving frame attached to the blade root motion. The BD_InputGlobalLocal is no longer necessary and leads to confusion when reading the code.
There is some additional code cleanup that can be done when removing this routine.
The text was updated successfully, but these errors were encountered:
To clarify, PR #1771 still uses the BD_InputGlobalLocal routine, so some logic and data modifications are needed to remove it properly. The inputs still need to be transformed into the states reference frames during calculations, but should not be transformed in bulk as it is currently done -- instead transform during the calculations.
BeamDyn includes an additional layer of coordinate transformations that is no longer necessary and breaks the framework. Prior to pull request #1771, all BeamDyn states were calculated against a fixed reference frame set by the initial blade root reference position. During a call to CalcOutput or UpdateStates, the inputs were copied and transformed into this reference by the
BD_InputGlobalLocal
routine.After #1771, the reference frame for all states has been changed to a moving frame attached to the blade root motion. The
BD_InputGlobalLocal
is no longer necessary and leads to confusion when reading the code.There is some additional code cleanup that can be done when removing this routine.
The text was updated successfully, but these errors were encountered: