Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeamDyn: Remove BD_InputGlobalLocal() routine #1790

Open
andrew-platt opened this issue Oct 3, 2023 · 1 comment
Open

BeamDyn: Remove BD_InputGlobalLocal() routine #1790

andrew-platt opened this issue Oct 3, 2023 · 1 comment
Assignees
Milestone

Comments

@andrew-platt
Copy link
Collaborator

BeamDyn includes an additional layer of coordinate transformations that is no longer necessary and breaks the framework. Prior to pull request #1771, all BeamDyn states were calculated against a fixed reference frame set by the initial blade root reference position. During a call to CalcOutput or UpdateStates, the inputs were copied and transformed into this reference by the BD_InputGlobalLocal routine.

After #1771, the reference frame for all states has been changed to a moving frame attached to the blade root motion. The BD_InputGlobalLocal is no longer necessary and leads to confusion when reading the code.

There is some additional code cleanup that can be done when removing this routine.

@andrew-platt andrew-platt added this to the v4.1.0 milestone Oct 3, 2023
@andrew-platt andrew-platt self-assigned this Oct 3, 2023
@andrew-platt
Copy link
Collaborator Author

To clarify, PR #1771 still uses the BD_InputGlobalLocal routine, so some logic and data modifications are needed to remove it properly. The inputs still need to be transformed into the states reference frames during calculations, but should not be transformed in bulk as it is currently done -- instead transform during the calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant