Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenFAST C++ Interface Not Writing Velocity Data Files #438

Closed
mchurchf opened this issue Apr 16, 2020 · 0 comments · Fixed by #445
Closed

OpenFAST C++ Interface Not Writing Velocity Data Files #438

mchurchf opened this issue Apr 16, 2020 · 0 comments · Fixed by #445
Assignees

Comments

@mchurchf
Copy link

C++ Interface Velocity Data Write Out Line Needs to Be Uncommented
The OpenFAST C++ interface has been set up to write out aerodyn node velocity data each time step to an hdf5 file. That happens at:

//writeVelocityData(velNodeDataFile, iTurb, nt_global, cDriver_Input_from_FAST[iTurb], cDriver_Output_to_FAST[iTurb]);

As you can see, by going to this line, the call to writeVelocityData is currently commented. It should be uncommented for proper behavior. As it is right now, the velocity data file is opened, but since it is not written to, it is filled with zeros. This is especially problematic because the user will not readily notice that anything has gone wrong because the file exists, and OpenFAST will even read it for restarts, but it will be reading zero velocity. When doing production OpenFAST-coupled CFD runs, the user may not notice a problem until the expensive run is complete and he/she goes to analyze the data.

To Fix
Uncomment the line shown here:

//writeVelocityData(velNodeDataFile, iTurb, nt_global, cDriver_Input_from_FAST[iTurb], cDriver_Output_to_FAST[iTurb]);
and the problem is fixed.

Expected behavior
The expected behavior is that the hdf5 velocity data files are written to as the C++ interface sends velocity data from the external C++ code (like a CFD solver) to OpenFAST. One can see that as the solvers run, the size of the hdf5 velocity data files increase over time. If you use something like h5dump to view the file contents, you should see non-zero values (unless you are doing a zero motion case).

@mchurchf mchurchf changed the title Bug report OpenFAST C++ Interface Not Writing Velocity Data Files Apr 16, 2020
@sayerhs sayerhs linked a pull request Apr 27, 2020 that will close this issue
@rafmudaf rafmudaf closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants