Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling to WriteVTK routine #477

Open
bjonkman opened this issue Jun 24, 2020 · 2 comments
Open

Add error handling to WriteVTK routine #477

bjonkman opened this issue Jun 24, 2020 · 2 comments
Labels
Type: Enhancement

Comments

@bjonkman
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the WriteVTK subroutine does not return an error status to alert the user if vtk files couldn't be written. This becomes more of an issue when attempting to create mode-shape files, introduced in #373, when the code may exit "normally" without actually generating any of the desired vtk files. @ebranlard pointed out this issue would occur if the user has deleted the vtk subdirectory between running the simulation and restarting it.

Describe the solution you'd like
Add ErrStat and ErrMsg arguments to WriteVTK, WrVTK_Surfaces, WrVTK_BasicMeshes, and WrVTK_AllMeshes routines. This involves adding error handling after every call to MeshWrVTK in those routines.
@bjonkman bjonkman mentioned this issue Jun 24, 2020
Merged
@rafmudaf rafmudaf mentioned this issue Sep 11, 2020
Merged
@rafmudaf
Copy link
Collaborator

@bjonkman Was this sufficiently addressed in #373?

@bjonkman
Copy link
Contributor Author

@rafmudaf : No, as far as I know this hasn't been addressed anywhere, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjonkman @rafmudaf