Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error: 2.1. Download binaries #650

Closed
vebjornmalmin opened this issue Jan 28, 2021 · 6 comments
Closed

Documentation error: 2.1. Download binaries #650

vebjornmalmin opened this issue Jan 28, 2021 · 6 comments

Comments

@vebjornmalmin
Copy link

vebjornmalmin commented Jan 28, 2021

The link to Windows binaries is 404. 2.1. Download binaries
"All precompiled binaries can be found in the Assets dropdown in the GitHub Releases. To download the latest binaries, click here."

The Asset dropdown is not easy to find either , ie I have not managed to located it.

EDIT:
Never mind the Asset comment, found it at the bottom of the release. But the link in Docs should be https://github.com/OpenFAST/openfast/releases/download/v2.5.0/openfast_v2.5.0_binaries.zip

@andrew-platt
Copy link
Collaborator

Thanks for pointing that out. We will update the link in the next release.

@Echolon
Copy link

Echolon commented Feb 19, 2021

Hi,

wouldn't it be better to just provide the general link: https://github.com/OpenFAST/openfast/releases

If you want I can offer to make a PR for you.

@rafmudaf
Copy link
Collaborator

Ah the link is broken because I named the archive openfast_v2.5.0_binaries.zip instead of the convention we were using of windows_openfast_binaries.zip.

@Echolon the releases page is also linked in the documentation. The two sentences related to this are:

"All precompiled binaries can be found in the Assets dropdown in the GitHub Releases. To download the latest binaries, click here."

When we were only linking to the Releases page, it was difficult to find the Assets dropdown after the release notes so I added a link to that directly.

@Echolon
Copy link

Echolon commented Feb 19, 2021

Ah okay - so not PR necessary?

Are there any other beginner task here? I am really interested to support.
If you need organizational help, I can offer to label all unlabeled issues. I did that work already for Jitsi Meet and the Monal IM repository.

@rafmudaf
Copy link
Collaborator

Hold off on making this change for now. I prefer to name the archives with the version number, but we do need to fix the broken link in the documentation.

There are a few issues labeled "Help Wanted": Help wanted
Specifically, the script to convert input files between versions would be very useful.

@rafmudaf
Copy link
Collaborator

rafmudaf commented Mar 9, 2021

This is addressed in #682

@rafmudaf rafmudaf closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants