Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApacheHttpClient - enable/disable follow redirect via Request.Options #1859

Open
trumple opened this issue Nov 23, 2022 · 2 comments
Open

ApacheHttpClient - enable/disable follow redirect via Request.Options #1859

trumple opened this issue Nov 23, 2022 · 2 comments

Comments

@trumple
Copy link
Contributor

trumple commented Nov 23, 2022

Hi there.

With spring-cloud-openfeign, it is possible to specify feign configuration by client with :

feign:
    client:
        config:
            feignName:
                connectTimeout: 1000
                follow-redirects: false

But when using the ApacheHttpClient, the property follow-redirects is ignored (whereas connectTimeout is ok)

I think it could be achieve by adding :

.setRedirectsEnabled(options.isFollowRedirects())

line 95 of ApacheHttpClient

@velo
Copy link
Member

velo commented Nov 24, 2022

line 95 of ApacheHttpClient

feel free to open a pull request. Please include tests.

@trumple
Copy link
Contributor Author

trumple commented Nov 25, 2022

#1861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants