Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of OAuth2 flows in Feign #2680

Open
hosuaby opened this issue Nov 30, 2024 · 2 comments
Open

Integration of OAuth2 flows in Feign #2680

hosuaby opened this issue Nov 30, 2024 · 2 comments

Comments

@hosuaby
Copy link
Contributor

hosuaby commented Nov 30, 2024

Hello @velo

I am starting working on the integration of OAuth2 client flows into Feign. I am opening this issue first.

Reason one: to evaluate the public interest for this feature.

Reason two: as this is not an easy task, I will need to ask for your opinions and suggestions during the development.

Are you agreeing to proceed like that? Or do you prefer to move discussion on Gitter?

@velo
Copy link
Member

velo commented Nov 30, 2024

Reason one: to evaluate the public interest for this feature.

Quite sure the interest to get the feature exists.... not sure if enough interest to contribute

Reason two: as this is not an easy task, I will need to ask for your opinions and suggestions during the development.

My main ask would be to concentrate the work on a new module dedicated to that. Changes to core might be needed and welcome (as long you don't break code compatibility and don't add dependencies to core, anything is fair game)

Are you agreeing to proceed like that?

I have a very, very, very limited amount of time that I'm willing to spend on this. If you expect more than a whole hour from me I can't commit to it. Full time dad first, full time worker second. Unless you want to hire me to develop tge feature. This is how strip for time I am: https://github.com/OpenFeign/querydsl/blob/master/.github/ISSUE_TEMPLATE/bug_report.md

@hosuaby
Copy link
Contributor Author

hosuaby commented Nov 30, 2024

@velo No problem, man. I don't ask you to code it for me. I will take care of development. I just will need to ask you some questions when they arise and validate a few architectural choices to integrate a new module with core as seamlessly as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants