Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback support for FeignClient #837

Open
sthallapalli opened this issue Nov 9, 2018 · 8 comments
Open

Callback support for FeignClient #837

sthallapalli opened this issue Nov 9, 2018 · 8 comments
Labels
proposal Proposed Specification or API change waiting for votes Enhancements or changes proposed that need more support before consideration

Comments

@sthallapalli
Copy link

Does Feign client supports Callbacks? I am not able find any example for doing it.
@velo
Copy link
Member

velo commented Nov 13, 2018

Not at the moment.

That would be something that needs to be implemented

@sthallapalli
Copy link
Author

sthallapalli commented Nov 13, 2018 •
edited
Loading

Do we have any ticket already?

@velo
Copy link
Member

velo commented Nov 13, 2018

If you decide to implement it, just report progress here and I will be notified.

@rage-shadowman
Copy link
Contributor

I remember seeing a PR a while ago for CompletableFuture support. That might be an equivalent thing?

@rage-shadowman
Copy link
Contributor

Found it: #638

@kdavisk6 kdavisk6 added enhancement For recommending new capabilities help wanted Issues we need help with tackling labels Nov 19, 2018
@kdavisk6
Copy link
Member

kdavisk6 commented Dec 5, 2018

@sthallapalli

Can you provide an example of what you are looking to do?

@kdavisk6
Copy link
Member

kdavisk6 commented Dec 5, 2018

@rage-shadowman

Support for CompleteableFuture in #638 is limited to those that use Hystrix only.

@kdavisk6 kdavisk6 added proposal Proposed Specification or API change and removed enhancement For recommending new capabilities labels May 28, 2019
@kdavisk6 kdavisk6 added waiting for votes Enhancements or changes proposed that need more support before consideration and removed help wanted Issues we need help with tackling labels Dec 30, 2019
@wangzihaogithub
Copy link

Does the current version work with CompleteableFuture?
I can't find a use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Proposed Specification or API change waiting for votes Enhancements or changes proposed that need more support before consideration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@velo @rage-shadowman @kdavisk6 @wangzihaogithub @sthallapalli