Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: rewrite to use new helper functions #316

Closed
josephjclark opened this issue Jul 26, 2023 · 0 comments · Fixed by #373 or #457
Closed

http: rewrite to use new helper functions #316

josephjclark opened this issue Jul 26, 2023 · 0 comments · Fixed by #373 or #457
Assignees

Comments

@josephjclark
Copy link
Collaborator

josephjclark commented Jul 26, 2023

With the introduction of new http helpers based on unidici, we need to re-write language-http to use the new helpers.

It should also use the new expandReferences utility function.

At the time of writing, we will need to handle expandReferences if options.body is a stream. I think is it reasonable to add logic for this in the new expandReferences utility (ie, don't recurse into a stream object, which we should be able to duck type)

This is a major version bump as the axios export and axios APIs are being removed.

I would like to change the http signatures as little as possible I think - so we should still have get(path, params, callback).

We will have to go through mapToAxiosConfig and decide which properties to maintain and which to drop. I would prefer to support a much smaller API.

It may be helpful to review existing http job code to get a sense of how difficult migration is going to be.

@mtuchi mtuchi self-assigned this Aug 10, 2023
@mtuchi mtuchi linked a pull request Aug 30, 2023 that will close this issue
15 tasks
@mtuchi mtuchi mentioned this issue Aug 31, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants