You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the introduction of new http helpers based on unidici, we need to re-write language-http to use the new helpers.
It should also use the new expandReferences utility function.
At the time of writing, we will need to handle expandReferences if options.body is a stream. I think is it reasonable to add logic for this in the new expandReferences utility (ie, don't recurse into a stream object, which we should be able to duck type)
This is a major version bump as the axios export and axios APIs are being removed.
I would like to change the http signatures as little as possible I think - so we should still have get(path, params, callback).
We will have to go through mapToAxiosConfig and decide which properties to maintain and which to drop. I would prefer to support a much smaller API.
It may be helpful to review existing http job code to get a sense of how difficult migration is going to be.
The text was updated successfully, but these errors were encountered:
With the introduction of new http helpers based on
unidici
, we need to re-writelanguage-http
to use the new helpers.It should also use the new
expandReferences
utility function.At the time of writing, we will need to handle
expandReferences
ifoptions.body
is a stream. I think is it reasonable to add logic for this in the newexpandReferences
utility (ie, don't recurse into a stream object, which we should be able to duck type)This is a major version bump as the
axios
export andaxios
APIs are being removed.I would like to change the http signatures as little as possible I think - so we should still have
get(path, params, callback)
.We will have to go through
mapToAxiosConfig
and decide which properties to maintain and which to drop. I would prefer to support a much smaller API.It may be helpful to review existing http job code to get a sense of how difficult migration is going to be.
The text was updated successfully, but these errors were encountered: