You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The options parameter is misleading. The value passed as options will be passed as the URL query. So actually, we should rename this parameter to params (which is consistent with commcare.get). A good description would be An object of query parameters to be encoded into the URL.. We should include an example of a request with a query and show how that maps to the actual URL that will be called (like we do with get)
RequestOptions is not a link. Turns out there is no typedef for RequestOptions. But actually there should not be - options should have a type of object, not RequestOptions
There is an argument that options should actually be options, in which case it accepts { headers, query, parseAs ...} options which get fed into common http.
But that's not how the API works right now (I suspect this is a bug) and I don't want to raise a breaking change today)
The text was updated successfully, but these errors were encountered:
We've hit some issues on commcare's
request
docsoptions
parameter is misleading. The value passed asoptions
will be passed as the URL query. So actually, we should rename this parameter toparams
(which is consistent withcommcare.get
). A good description would beAn object of query parameters to be encoded into the URL.
. We should include an example of a request with a query and show how that maps to the actual URL that will be called (like we do with get)options
should have a type ofobject
, not RequestOptionsThere is an argument that
options
should actually be options, in which case it accepts{ headers, query, parseAs ...}
options which get fed into common http.But that's not how the API works right now (I suspect this is a bug) and I don't want to raise a breaking change today)
The text was updated successfully, but these errors were encountered: