-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: replace workerpool #412
Comments
This was referenced Oct 27, 2023
Some performance stats with workerpool:
This is based on 0336d31 |
It's becoming increasingly apparent that workerpool or worker threads won't work for us. It is not secure or stable enough. I've re-estimated (probably naively) based on this plan:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Workerpool is not going to fly for us because:
We need to investigate threads and piscina (or whatever), or maybe other libraries, so that we get the control we need.
We need to consider performance, stability and security. I'd like to have some kind of benchmark for this (a benchmark integration test would be nice - run the same 10 workflows 50 times and measure the total time).
The text was updated successfully, but these errors were encountered: