Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 20: ava fails in node 18.19.0 #542

Closed
josephjclark opened this issue Dec 11, 2023 · 0 comments
Closed

node 20: ava fails in node 18.19.0 #542

josephjclark opened this issue Dec 11, 2023 · 0 comments
Labels
bug Something isn't working tech debt Non-critical, invisible code issues that ought to be addressed

Comments

@josephjclark
Copy link
Collaborator

Node 18.18.2 is absolutely fine.

Node 18.19.0 breaks ava.

What's happening SOMEHOW is the ts-node esm loader, which we use to run our ava tests, breaks against the very latest node. At least for the worker-threaded approach (forcing ava to run with child processes works fine).

I think we SHOULD be using @ava/typescript and not ts-node/esm to handle the typescript tests. But @ava/typescript fails for me, even in a minimal testing project, and I can't work it out. See #541 for notes on that.

The build, so far as I can tell, is unaffected.

As a wider note our node version is quickly drifting out of date and we really ought to get on a 20x version (if not 21 soon). I wonder too if we should run our integration test suite against LTS 18 and 20 as well as the latest node build - just to ensure stability.

@josephjclark josephjclark added bug Something isn't working tech debt Non-critical, invisible code issues that ought to be addressed labels Dec 11, 2023
@taylordowns2000 taylordowns2000 moved this to Icebox in v2 Feb 3, 2024
@josephjclark josephjclark changed the title ava fails in node 18.19.0 node 20: ava fails in node 18.19.0 Dec 1, 2024
@github-project-automation github-project-automation bot moved this from Icebox to Done in v2 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech debt Non-critical, invisible code issues that ought to be addressed
Projects
Archived in project
Development

No branches or pull requests

1 participant