Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker: Support MAX_DATACLIP_SIZE #571

Closed
josephjclark opened this issue Jan 25, 2024 · 1 comment
Closed

Worker: Support MAX_DATACLIP_SIZE #571

josephjclark opened this issue Jan 25, 2024 · 1 comment

Comments

@josephjclark
Copy link
Collaborator

The worker should check (estimate?) the seize of a serailzed dataclip and not bother to send it if exceeds MAX_DATACLIP_SIZE.

It should log that it did this.
@josephjclark
Copy link
Collaborator Author

The CLI could log the size of the serialized state object at the end of each step. This would be nice feedback at devtime.

Also, in the CLI, if the state object is > 10mb (which I presume is the default MAX_DATACLIP_SIZE), we should console.warn it

@josephjclark josephjclark mentioned this issue Jul 31, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v2
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephjclark