-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker: remove secret from env #773
Comments
Obviously you can't just do process.env, you have to properly unset it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The worker start script, once the server has started, should delete WORKER_SECRET from the env.
This ensures that once the worker instance has the secret in memory, any attacker on the server can no longer access it.
This also means that the server can't be restarted without the container being destroyed (which is probably good)
The text was updated successfully, but these errors were encountered: