Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker: allow collection credentials to be passed per on on run options #814

Open
josephjclark opened this issue Nov 7, 2024 · 0 comments
Open

Worker: allow collection credentials to be passed per on on run options #814

josephjclark opened this issue Nov 7, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

The worker currently sets "global" defaults for the collection URL and version at startup time (form env vars)

But maybe this is too much, and unnecessary, control from the worker.

So we should enable a Run to include collections_endpoint and collections_version in its options, which should override the worker default.

This lets Lightning decide what collection version is used. It can even decide per-project if it wants to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v2
Status: New Issues
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephjclark