Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding test cases #52

Open
ijpulidos opened this issue Sep 26, 2024 · 1 comment
Open

Expanding test cases #52

ijpulidos opened this issue Sep 26, 2024 · 1 comment

Comments

@ijpulidos
Copy link
Contributor

We have some tests running in the CI, but since atom mapping could have so many corner cases I think it's valuable that we expand the tests for the atom mapper to more of these. This issue is intended at discussing which cases are desired to be tested. As far as I can think of, we would like to have at least the following tests that are related to protein/residue mutations.

  • Different capped AAs mapping. Some "key" cases and check that the mapped atoms are the expected ones.
  • Full protein mappings. Maybe a tyk2 with a mutated tyk2 or similar.
  • Mapping of proteins (or big molecules) on itself, we would expect every atom to be mapped.
  • Mapping big protein to small peptides/AAs or vice versa.

As usual more than coverage we want more test cases, so I think this is something somewhat desired. One caveat is that some of these tests could take a few minutes to make the whole mapping. But this could also be helpful to do benchmarking on our current implementation.

@ijpulidos
Copy link
Contributor Author

Just wanted to note that we are including some tests for multimeric protein component mappings in #47 , but while working on that I realize that we probably also want to have more tests at different levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant