Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Network generators factories? #68

Open
IAlibay opened this issue Aug 27, 2024 · 2 comments
Open

Are Network generators factories? #68

IAlibay opened this issue Aug 27, 2024 · 2 comments
Labels
Konnektor refactor Good Infrastrucutre / Refactoring

Comments

@IAlibay
Copy link
Member

IAlibay commented Aug 27, 2024

Usually I expect a Generator to have __iter__ defined, but the pattern used seems a lot closer to a factory pattern.

Would it make sense to not call it "Generator" to avoid Python confusion?

@RiesBen RiesBen added refactor Good Infrastrucutre / Refactoring Konnektor labels Sep 11, 2024
@atravitz
Copy link
Contributor

atravitz commented Oct 28, 2024

In conversation with @RiesBen, we think that Creator might be a more accurate term. But there is a code example in the paper draft using Generator.

@IAlibay we are find with making this Generator -> Creator name change quickly before publishing. Any concerns?

@RiesBen
Copy link
Contributor

RiesBen commented Oct 28, 2024

In conversation with @RiesBen, we think that Creator might be a more accurate term. But there is a code example in the paper draft using Generator.

@IAlibay we are find with making this Generator -> Creator name change quickly before publishing. Any concerns?

After discussions, this is might be an interesting suggestion for the future. For now we will not follow up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Konnektor refactor Good Infrastrucutre / Refactoring
Projects
None yet
Development

No branches or pull requests

3 participants