Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get macos-12+, including osx-arm64 (i.e. macos-latest) runners working in CI #842

Open
IAlibay opened this issue Apr 25, 2024 · 5 comments
Assignees

Comments

@IAlibay
Copy link
Member

IAlibay commented Apr 25, 2024

Follow-up from #841 (review)

@IAlibay IAlibay changed the title Get osx-arm64 (i.e. macos-latest) runners working in CI Get macos-12+, including osx-arm64 (i.e. macos-latest) runners working in CI Apr 26, 2024
@IAlibay
Copy link
Member Author

IAlibay commented Apr 26, 2024

Overview of issue

  • macos-13 (x86_64) is not compatible with the current conda-forge deployments of AT22 or AT23. The wheels will get picked up and installed, but SQM will fail
  • macos-14 (osx-arm64) does not have compatible AmberTools wheels

TODO:

  • unpin openfe CI
  • unpin gufe CI
  • unpin ExampleNotebooks CI
  • ...

@IAlibay
Copy link
Member Author

IAlibay commented Nov 12, 2024

This has either been addressed or moved to other issues.

The lack of compatibility between AT and macos-13 is an issue that will need a look at.

@IAlibay IAlibay closed this as completed Nov 12, 2024
@atravitz
Copy link
Contributor

This has either been addressed or moved to other issues.

The lack of compatibility between AT and macos-13 is an issue that will need a look at.

@mikemhenry do you know if any recent ambertools builds are compatible with macos-13? If not, we will drop our support of macos-13 as well.

@atravitz atravitz reopened this Nov 13, 2024
@mikemhenry
Copy link
Contributor

That is a good question, recent versions no, but older versions yes? I think the easiest way to check is to see if an env will solve os macos-13 with ambertools 22, 23, or 24. You might need to check python versions 3.9-3.12, since there might be a sweet spot where it all algins.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 14, 2024

@mikemhenry the issue isn't so much that it doesn't resolve but that there's an issue with the binary - i.e. if you run SQM it'll fail horribly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants