Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpolation is computed twice #1470

Open
yukiiwashita opened this issue Jan 12, 2017 · 2 comments
Open

Interpolation is computed twice #1470

yukiiwashita opened this issue Jan 12, 2017 · 2 comments
Labels
Type:Enhancement

Comments

@yukiiwashita
Copy link
Contributor

Due to #1464, interpolant coefficients for piecewise polynomial interpolators are computed twice if node sensitivity is requested.
@jodastephen
Copy link
Member

Is this a problem, or just inefficient? There is no way to get node sensitivity later as far as I can see.

@yukiiwashita
Copy link
Contributor Author

yukiiwashita commented Jan 17, 2017 •
edited
Loading

Changed the label. This is inefficient especially when doing calibration with e.g.,CubicSplineInterpolator where the node sensitivity computation is requested every step, then the linear system is solved twice.
For several piecewise polynomial interpolators, determining coefficients is not required to calculate coefficient sensitivities, while these two share some variables, e.g., intervals, gradients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type:Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jodastephen @yukiiwashita