Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange results searching for xyz in three.js #66

Closed
OndrejSpanel opened this issue May 19, 2020 · 4 comments
Closed

Strange results searching for xyz in three.js #66

OndrejSpanel opened this issue May 19, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@OndrejSpanel
Copy link
Member

OndrejSpanel commented May 19, 2020

Searching for xyz in mrdoob/three.js leads to some strange results:

Observation: The xyz is found in the source blocks in both cases.

@OndrejSpanel OndrejSpanel added the bug Something isn't working label May 19, 2020
@OndrejSpanel OndrejSpanel self-assigned this May 19, 2020
@OndrejSpanel
Copy link
Member Author

  • the whole source seems to be highlighted

Fixed (class=highlight was already used in the GitHub markdown, changed to search-highlight on our end)

@OndrejSpanel
Copy link
Member Author

no comment is highlighted

The issue is loaded on a second page (by pressing Load more issues). The page loading does not submit the required Accept header, therefore text match information is missing for subsequent pages.

@OndrejSpanel
Copy link
Member Author

Another similar situation: CSM in three.js returns several matches into https://www.github.com/mrdoob/three.js/issues/18934

Responses 4 and 5 are not highlighted in spite of them containing the CSM (and the word itself is highlighted when viewing the comment).

@OndrejSpanel
Copy link
Member Author

It seems in this case a little can be done, as GitHub API returns the two matches only:

The fact they are highlighted in-line is a side effect of the highlights being done brute force, with no respect to what highlight comes from where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant