Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Majestic night mode settings allow only one illumination pin #265

Open
plush opened this issue Feb 11, 2024 · 1 comment
Open

Majestic night mode settings allow only one illumination pin #265

plush opened this issue Feb 11, 2024 · 1 comment

Comments

@plush
Copy link

plush commented Feb 11, 2024

The illumination for night mode can be configured in two places:

  • The "Illumination" settings page
  • The Majestic settings "Night Mode" tab

On the "Illumination" settings page (/var/www/cgi-bin/config-light.cgi), separate GPIO pins can be set for 850 nm and 940 nm IR LEDs, and both are saved to the firmware environment as ir850_led_pin and ir940_led_pin. However, only one of the pins is written to .nightMode.backlightPin and this is the only variable/ pin that the Majestic settings "Night Mode" tab can deal with.

Having support for two LED pins in some parts of the system and only one in others leads to inconsistencies: On the preview page, you can toggle both LEDs (even separately). But the /usr/sbin/irled.sh script will only toggle the one LED stored in Majestic settings.

It would be great to take into account both LEDs throughout and turn both of them on/off as night mode is toggled.

@flyrouter
Copy link
Member

Good afternoon, thank you for your interest in the project.
These are experimental sections and I think in the near future decisions will be made on how to manage them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants