Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Do not change menu items while the cursor is inside #153

Closed
igorkulman opened this issue Aug 8, 2020 · 3 comments · Fixed by #183
Closed

[Feature Request] Do not change menu items while the cursor is inside #153

igorkulman opened this issue Aug 8, 2020 · 3 comments · Fixed by #183
Labels
enhancement New feature or request

Comments

@igorkulman
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The menu now refreshes on a fixed timer. When I want to connect to a network and the refresh takes place the menu item under the cursor changes and I click wrong item (network).

Describe the solution you'd like
Do not refresh menu items while the cursor is inside the open app menu. Just when the cursor is outside of the menu. The changes coming in while the cursor is inside the menu can be queued and then when cursor leaves the menu just the last change is applied.

Describe alternatives you've considered
Being faster when clicking but it is a timing issue.

@ErrorErrorError
Copy link
Collaborator

Well if the items aren't refreshed when you have the menu open then the items would always show that they are available even if you are out of range. List fetching is done from itlwm and retains those fetches as cache

@igorkulman
Copy link
Contributor Author

Refreshing when menu open would be OK when the cursor is outside it, on the icon in menu bar or totally outside. My thinking is that you click the icon, the menu opens, you wait for the network you want to connect to appear and then move the cursor to click it. At that point you want the item not to move so you hit it.

@williambj1 williambj1 added the enhancement New feature or request label Aug 8, 2020
@Goshin
Copy link
Collaborator

Goshin commented Aug 8, 2020

I think we can simply do an early return in the network list updating if the cursor is over the network list section of the menu, so it will not be affected if the cursor is over other function items like "Turn off WiFi" etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

4 participants