Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to Piper download #100

Closed
aaronsdevera opened this issue Mar 22, 2024 · 2 comments
Closed

Update link to Piper download #100

aaronsdevera opened this issue Mar 22, 2024 · 2 comments

Comments

@aaronsdevera
Copy link

Describe the bug
When running 01 locally, piper fails to download due to a bad url.

To Reproduce
Steps to reproduce the behavior:

  1. on macOS, run poetry run 01 --local in the /software dir without piper model downloaded
  2. See error

Expected behavior
01 is supposed to go and download piper via the defined URL:

PIPER_URL = "https://github.com/rhasspy/piper/releases/latest/download/"

However I am not aware if GitHub supports these types of URLs any longer. For instance, https://github.com/rhasspy/piper/releases/latest/ will redirect you to the page on GitHub for the latest release. Adding download to that URL will redirect to a GitHub 404.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • macOS
  • python3.11
@quentinsteinke
Copy link

@aaronsdevera if you have the entire file name, not just to the latest folder, it will actually download it. I have tried it and got it working on my macOS using python3.11. The error is because of a ssl certificate validation problem. I am not sure what is wrong though. If I make it so the https request doesn't have to be verified (which you shouldn't do) in the tts.py, it works as intended.

@tyfiero
Copy link
Contributor

tyfiero commented Mar 28, 2024

I believe this has been fixed with the latest merged pull requests. If the issue arises again, please create a new issue!

@tyfiero tyfiero closed this as completed Mar 28, 2024
This was referenced Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants