[WIP] Moving tests to use VTN #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Thayer <joshuamilesthayer@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 42 42
Lines 5728 5734 +6
=======================================
+ Hits 4736 4741 +5
- Misses 992 993 +1 ☔ View full report in Codecov by Sentry. |
pohlm01
approved these changes
Dec 3, 2024
|
@joshuathayer Just a kind check if you still intend to continue working on that. This issue is not a priority to us currently, so feel free to take your time. Nevertheless, it would be nice to know if we can expect any progress in the future or if you would like to hand over the work to someone else. If you got any organizational or technical questions, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR for #63 to make sure this general shape makes sense. I'm taking a lot of inspiration from the test files which already avoid accessing the DB directly, in particular putting all the test functionality in a single
crudtest.I've left the existing tests that haven't been moved away from using the DB directly in place- ie,
delete,update_same_name, etc. Once those tests have been moved to use the server, I'll remove the existing tests.Please take a look @pohlm01!