Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide quick fix for undefined property reference in server.xml #69

Open
cherylking opened this issue Jun 10, 2022 · 2 comments
Open
Assignees
Labels
enhancement New feature or request high priority LemMinX Liberty extension to Eclipse Lemminx

Comments

@cherylking
Copy link
Member

cherylking commented Jun 10, 2022

If a property reference in server.xml is not defined within server.xml, bootstrap.properties or server.env, then provide a quick fix to create a variable with that property name in the server.xml file.

This is a future enhancement and not part of the MVP. Slide 28 of UFO.

@cherylking cherylking added the enhancement New feature or request label Jun 10, 2022
@evie-lau evie-lau added the LemMinX Liberty extension to Eclipse Lemminx label Aug 24, 2022
@cherylking
Copy link
Member Author

Should probably give the user options of where to create the variable - current xml file, bootstrap.properties, server.env, maybe even configDropins or the following location which I think is somewhat new for specifying variables:

Screenshot 2023-11-07 at 11 12 10 AM

@scottkurz
Copy link
Member

scottkurz commented Dec 8, 2023

Just noting that WDT/LDT has this support, at least for unresolved variable refs in server.xml, and it also seems to be applied to the merged config (include & dropins). Not that this moves us forwards a whole lot..just noting.

The WDT diagnostic would say something like:

 - The property 'destinationType', for the element 'properties.wasJms', contains an undefined variable reference 'abc'

@cherylking cherylking moved this from Target fix release to Target feature release in Liberty Tools Release Plan Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority LemMinX Liberty extension to Eclipse Lemminx
Projects
Status: Target feature release
Development

No branches or pull requests

4 participants