Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide multi-module-aware Run/Debug Configuration with appropriate defaults, and caching of custom-selected values. #491

Open
scottkurz opened this issue Feb 1, 2024 · 0 comments
Milestone

Comments

@scottkurz
Copy link
Member

scottkurz commented Feb 1, 2024

There are logically two new fields here (final names TBD):

  1. Aggregator (or "top-level", or "root") module home
  2. Liberty server module

We map 1. to the working directory and the pom.xml of the invocation, and we map 2. to the -pl <module> value.

DESIGN

  • When an aggregate module is selected, it itself should be defaulted as the value of 1. The value of 2. can be blank, which means we will delegate to liberty-maven-plugin to figure out where dev mode should run.

  • When a aggregated (sub)module is selected, we use the aggregation model to determine the aggregator module, which we default to be the value of 1., and the value of 2. will be set to the selected module itself.

  • Note we do NOT at this point commit to disallowing or filtering out non-server modules, whether because they are JAR packaging types or even WAR packaging types that are not suitable for some reason.

  • In Eclipse, we already persist custom values (parms) set on the run configuration. For IDEA and VSCode, we should make sure we do this too.

OTHER NOTES

Note there might also be a need/desire to subclass the Gradle vs. Maven Run config control here, to only show the multi-module components in the Maven one.

Though it could also be desirable to only show this for projects we calculate to be Maven multi-module projects, we might still want to include the fields for ANY Maven multi-module, so that they can reference other projects in the OS filesystem, not just workspace projects.

@scottkurz scottkurz added this to the 24.0.6 milestone Feb 1, 2024
@scottkurz scottkurz changed the title Provide multi-module-aware Run/Debug Configuration with appropriate defaults Provide multi-module-aware Run/Debug Configuration with appropriate defaults, and caching of custom-selected values. Feb 9, 2024
@scottkurz scottkurz modified the milestones: 24.0.6, 24.0.9 Apr 26, 2024
@awisniew90 awisniew90 modified the milestones: 24.0.9, 24.0.12 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants